I’m having an error with any of your new addons that use your new tooltip code. I have tracked it down to an incompatibility with AllInOneInventory. It’s causeing a error whenever I mouse over an item in my inventory. The error is a nil value for frame on line 182 of GFWTooltip.lua.
Feed-O-Matic is causing problems in EnhTooltips. I have no earthly clue why this is.
For Auctioneer and some other plug in’s we need to use the “Release” 1.06 version of EnhTooltips you must be doing some custom calling into that.
Disabling your add in solves the problem. The error only occurs when looting from the loot window if that helps you any, and it is a specific error in EnhTooltips (again release 1.06 NOT the one that you have in your other add ons). Error occurs on all looting actions including skinning.
I would assume it has something to do with the new GFWTooltips.lua file.
I would sugest rolling back to 1700.4 codebase as Enhtooltips modification issues would effect a great many of the “loot linkish” add ons. If you are modifying a custom Enhtooltips or duplicating functionality this could be causing a double trap.
Of course I don’t know the code base that well and am mearly offering sugestions..
My last comment sure came out weird. In case you can’t figure it out, modify lines 287 and 288 in GFWTooltip.lua changing the parameters from (slot) to (this, slot). This fixes the error I’m seeing with Enhtooltip.
I’m guessing the first error with AllInOneInventory and one as yet unreported in MyInventory can be fixed by fixing lines 479 and 495 in GFWTooltip.lua. The variable frame is undefined in both functions. I don’t use either one of those addons.
Could you change the FoodOMaticFood.lua to use item id’s instead of names? If modified a version which works with ids, so its much easier to localize. You would only need to translate the foodnames and bagtypes (quiver/ammo).
AutoBar (ive got the idea off that addon) has a good list of ids for food (not categorized).
I really love your addon but as german player i always need to modify the code to work. What you think about this change?
Yes, I intend to switch this and Disenchant Predictor over to using item IDs for locale-independence soon, though Feed-O-Matic will require a lot more localized text just for functional compatibility (we have to parse several system messages, combat log messages, tooltip spell descriptions, and other things to do everything Feed-O-Matic does).
To leave feedback on a Fizzwidget Industries product, visit us on Github. There you can report bugs, contribute enhancements, or just live on the bleeding edge.
September 27th, 2005 at 7:02 pm
I’m having an error with any of your new addons that use your new tooltip code. I have tracked it down to an incompatibility with AllInOneInventory. It’s causeing a error whenever I mouse over an item in my inventory. The error is a nil value for frame on line 182 of GFWTooltip.lua.
September 27th, 2005 at 8:56 pm
Feed-O-Matic is causing problems in EnhTooltips. I have no earthly clue why this is.
For Auctioneer and some other plug in’s we need to use the “Release” 1.06 version of EnhTooltips you must be doing some custom calling into that.
Disabling your add in solves the problem. The error only occurs when looting from the loot window if that helps you any, and it is a specific error in EnhTooltips (again release 1.06 NOT the one that you have in your other add ons). Error occurs on all looting actions including skinning.
I would assume it has something to do with the new GFWTooltips.lua file.
To reporduce if you want to
Go loot.
Is 1700.4 anywhere?
September 27th, 2005 at 9:04 pm
Test Confirmed 1700.4 does not cause this issue.
I would sugest rolling back to 1700.4 codebase as Enhtooltips modification issues would effect a great many of the “loot linkish” add ons. If you are modifying a custom Enhtooltips or duplicating functionality this could be causing a double trap.
Of course I don’t know the code base that well and am mearly offering sugestions..
September 27th, 2005 at 10:01 pm
The fix is in GFWTooltip.lua:
287,288c287,288 < function GFWTooltipGameTooltipSetLootItem(slot)
< GFWTooltipOriginalGameTooltipSetLootItem(slot);
Note that if you also have GFW_AdSpace installed you have to change the same file in that directory as well.
September 27th, 2005 at 10:18 pm
My last comment sure came out weird. In case you can’t figure it out, modify lines 287 and 288 in GFWTooltip.lua changing the parameters from (slot) to (this, slot). This fixes the error I’m seeing with Enhtooltip.
I’m guessing the first error with AllInOneInventory and one as yet unreported in MyInventory can be fixed by fixing lines 479 and 495 in GFWTooltip.lua. The variable frame is undefined in both functions. I don’t use either one of those addons.
September 27th, 2005 at 10:23 pm
Nice quick work Brad… 🙂
September 27th, 2005 at 11:40 pm
Hi
I just got the following error when looting a “Bright Eyeball”
Error:Interface\AddOns\GFW_FeedOMatic\GFWTooltip.lua:288: Invalid loot slot in SetInventoryItem
I saw others posting issues with Auctioneer/EnhTooltip, but I use KC_Items
September 28th, 2005 at 3:37 am
Could you change the FoodOMaticFood.lua to use item id’s instead of names? If modified a version which works with ids, so its much easier to localize. You would only need to translate the foodnames and bagtypes (quiver/ammo).
AutoBar (ive got the idea off that addon) has a good list of ids for food (not categorized).
I really love your addon but as german player i always need to modify the code to work. What you think about this change?
Thanks in advance, Acesolon
September 28th, 2005 at 5:40 am
YAY
Brad thanks for the fix it has been bugging me for days.
Another thing that doesn’t really matter, but the line 144 needs to be commented out to avoid an error on startup.
And Devla, you can use the same fix as Brad described.
And thanks to Fizz for making these great mods, I’m happy that it all works again 🙂
September 28th, 2005 at 10:58 am
1700.7 is up, which should fix these errors.
Yes, I intend to switch this and Disenchant Predictor over to using item IDs for locale-independence soon, though Feed-O-Matic will require a lot more localized text just for functional compatibility (we have to parse several system messages, combat log messages, tooltip spell descriptions, and other things to do everything Feed-O-Matic does).