Comments on: AdSpace 1800.2

By: Chocky

Chocky — Wed, 19 Oct 2005 01:48:45 +0000

Latest version of disenchant predictor no longer produces stack overflow error. Still happening in ad space.

By: Kahlan

Kahlan — Mon, 17 Oct 2005 18:19:49 +0000

Very nice, usefull mod. Told a guildmate about it, who kept paying too much on AH for vendor patterns (bit silly, I look up my plans before I spend to much, but this saves me time). No errors for me yet, just would like to say thank you and compliment you on your imaginative site

By: Chronnox

Chronnox — Sat, 15 Oct 2005 09:14:18 +0000

Hello Asjaskan

can you give a guide, how to put the line of code into the .lua?

which line do u insert the code?

bekomm das nicht hin...

oder per Email chronnox@gmx.de

Danke /thx

By: Asjaskan

Asjaskan — Fri, 14 Oct 2005 15:09:23 +0000

The server replaced a lot of the Underscores in my code above, I hope it's readable anyhow...

Asjaskan

By: Asjaskan

Asjaskan — Fri, 14 Oct 2005 15:02:49 +0000

First of all, thanks for this great mod!

I also got the "nil" Error in line 26 on my german client, and yesterday I decided to debug a bit...

As Flitzepfeil stated above, UnitFactionGroup(â€?playerâ€?) seems to always return the english name of the faction (returns "Alliance" for me), not the localized one. To compensate, I added a small function FAS_UnitFactionGroup (see below) to AdSpace.lua and replaced the two calls to UnitFactionGroup with calls to this new function:

... local myFaction = FAS_UnitFactionGroup("player"); ...

function FAS_UnitFactionGroup(object) local unitFaction = UnitFactionGroup(object); if ( unitFaction == "Alliance" ) then return FACTION_ALLIANCE; elseif ( unitFaction == "Horde" ) then return FACTION_HORDE; else return unitFaction; -- just to be on the save side... end end

Additionally, I tweaked the german localization:

RETURN_TO = "Zur\195\188ckbringen zu"; (the old phrase "Zurueckkehren zu" actually means that I myself should go back to the mentioned NSC, whereas my translation covers the actual meaning of returning the item to the NSC...)

SOLD_FOR_PRICE_BY = "Zu kaufen f\195\188r %s bei"; SOLD_BY = "Zu kaufen bei"; (these two are only cosmetic, but I think they sound a bit smoother...)

Greetings and keep up the good work, Asjaskan

By: Chocky

Chocky — Thu, 13 Oct 2005 23:56:05 +0000

This didn’t seem to be happening with .1 of the addons.

By: Chocky

Chocky — Thu, 13 Oct 2005 22:21:24 +0000

This and disenchant predictor are both throwing this error:

GFWTooltip.lua:396:stack overflow

when ever I move the mouse over anything that has a tooltip and the tooltip doesn't show.

Great addons, keep up the good work.

By: Dirtlyng

Dirtlyng — Thu, 13 Oct 2005 18:28:21 +0000

Cool. Thanks for the output

I thoroughly enjoy your mods, and your website is very cool too.

Keep up the grand work.

~Dirt

By: Gazmik Fizzwidget

Gazmik Fizzwidget — Thu, 13 Oct 2005 16:49:37 +0000

Actually, there are a number of exceptions to the white/green rule for vendor-sold recipes; several white recipes are available only as drops, and some green recipes are sold by vendors (though Blizzard does seem to be fixing these a few at a time with each patch). That there are still many such exceptions is the reason AdSpace was first created.

That particular one may be a fluke, though... it's inconsistently listed on the various WoW database sites.

By: Dirtlyng

Dirtlyng — Thu, 13 Oct 2005 16:26:17 +0000

Hi again,

AdSpace says that Formula: Enchant Gloves - Fishing is sold by Tharynn Bouden, Elywnn Forest, however, I don't believe this is true. (As far as I know, all Vendor-sold Formulas are Common (white) as opposed to Uncommon (Green).

Sincerely, Dirt

By: Flitzepfeil

Flitzepfeil — Thu, 13 Oct 2005 12:13:00 +0000

error: FAS_VendorInfo[myFaction] -> indexing a ? value client: german wow v1.8

problem: local myFaction = UnitFactionGroup("player"); returns "Alliance" not "FACTION_ALLIANCE"

dirty fix hack: change all `FAS_VendorInfo[myFaction]` to `FAS_VendorInfo[FACTION_ALLIANCE]`